87 Commits

Author SHA1 Message Date
15a55d4fd5 Add sanity for UdpSlot, message size shouldn't change across datagrams 2017-05-31 15:01:19 +02:00
ea3375e4a0 We should clear based on m_dgramToRead and not m_dgramToSend 2017-05-29 10:45:29 +02:00
709bd721ed Clear receive buffer if we're doing a full resend. The response may be different 2017-05-29 10:34:41 +02:00
9951b8ac0f Split UdpSlot::sendAck() into two clearly named methods 2017-05-26 12:20:22 +02:00
8834040c1e Initialize m_readBuf to 0xfe 2017-05-24 15:13:41 +02:00
0aedaf4227 More udpslot debug log 2017-05-23 15:05:30 +02:00
fda245daf7 Old logic seems to be wrong when calculating the size of the final datagram. Don't validate with old logic but instead use the simplified logic 2017-05-23 13:30:22 +02:00
4466825f52 Simplify UdpSlot::readDatagramOrAck logic 2017-05-23 12:11:20 +02:00
f980441da4 log bytes sent in UdpSlot 2017-05-21 23:22:33 +02:00
335284f682 Remove commented out code 2017-05-16 10:41:26 +02:00
c9eda468d0 Remove backoff & maxWait from UdpSlot::sendSetup (it's always set to -1) 2017-05-15 16:04:05 +02:00
7db9c4354e Removed non-renetrant version of iptoa()
Mass-change. Many places it could have been done in a better way (eg. calculate nice name for UdpSlot peer once and not for every log line).
2017-05-10 17:54:00 +02:00
1c117d3aa1 Dropped PingInfo + PingServer entierely.
The remaining functionality of the pingserver was to ping normalt and "shotgun" IPs to determine the fastests and working network path. This is better done at L2/L3 or OS level - not in the application.

The email-sending functionality was dropped too. We recommend using 3rd-party tools for monitoring and statistics-collection/triggering.
2017-05-05 15:00:31 +02:00
a8483620c1 Remove commented out code 2017-04-19 12:48:42 +02:00
66c45db9c0 Remoed unused UdpServer::printState() and UdpSlot::printState() 2017-04-07 13:03:36 +02:00
d24fa078eb Remvoed 'discard' paramter to UdpSlot::readDatagramOrAck()
Value was not used. Also the 'discard' local variabl was effectively not used in UdpServer::readSock()
2017-04-06 14:40:03 +02:00
122f99f680 Fix pinginfo resends and etryagains
Moved fields m_etryagains and m_totalResends from PingInfo to Host. Otherwise the counters were overwritten each time we got a response from that host making statistics wrong.
2017-04-06 12:10:42 +02:00
e2ef4acb9b Removed obsolete comments in UdpSlot::getScore() 2017-04-04 14:09:13 +02:00
217385db86 Simplified UdpSlot::getScore() a bit
'now' could never be 0. Removed logic dealing with that.
2017-04-04 14:06:14 +02:00
52a1507859 Removed Conf::m_interfaceMachine (non-functional) 2017-04-03 12:56:36 +02:00
52683da656 Removed Host::m_hostdb (was always &g_hostdb) 2017-04-03 11:56:19 +02:00
9ce07a3772 Stop returning (void *)0x7fffffff for zero-sized allocations
Mem.cpp was using that as a special marker for new/malloc/realloc zero-bytes allocations, but tests show that only UdpSlot had a harmless problem with NULL being returned. I seem to recall that Linkdb/Msg25 had an incorrect sanity check but no faults show up there anymore.
2017-02-19 15:03:54 +01:00
74d176279b Quell pclint warning about (harmless) implicit conversion of msg_type_t to int in log statements 2017-01-08 15:10:07 +01:00
cc12e05fab Use static strings for UdpSlot buffer memory labels 2017-01-03 23:45:36 +01:00
d52dabc828 #include cleanup of Url.h 2016-11-12 20:01:44 +01:00
1aee61ce48 #include clenaup 2016-11-11 16:35:45 +01:00
8b9fe504d1 if else/then was the same in UdpSlot (RESEND_0 was same as RESEND_0_SHORT) 2016-10-21 21:50:40 +02:00
3cccff5e1c Limit extraInfo to buffer size 2016-09-26 16:52:48 +02:00
8136e7ccf5 #include cleanup in UdpServer.* 2016-09-26 15:26:00 +02:00
80277cb3c6 Remove memcpy_ass and replace with gbmemcpy (it's the same anyway) 2016-09-22 14:31:16 +02:00
3ca51d7d79 Add constness 2016-08-11 13:04:53 +02:00
f06d8f1cf4 Code style changes, removing commented out code 2016-08-11 12:58:52 +02:00
15a8627162 Store extraInfo to UdpSlot::sendSetup function 2016-08-11 12:58:52 +02:00
88267f16f1 Remove dependency of UdpSlots from PageSockets 2016-08-11 12:58:51 +02:00
c29d416f96 #include cleanup in Proxy.* 2016-08-10 00:05:30 +02:00
ccf4eff8e4 Code style changes. Remove commented out code 2016-08-05 13:53:55 +02:00
09ed6d1a92 Remove commented out codes 2016-08-05 13:53:55 +02:00
db1ede90a2 Rearrange some if/else statements. Add log level. Simplify code. 2016-08-05 10:49:35 +02:00
1bd4bde84c Code style changes 2016-08-05 10:49:06 +02:00
1f7d51a81e Use logDebug 2016-08-04 16:38:41 +02:00
fa2f84a58e Code style changes 2016-08-04 16:38:41 +02:00
5e3a883615 Remove unnecessary cast of m_transId in UdpSlot 2016-08-04 16:38:41 +02:00
c3a671ed1e Remove replybuf & replybuf size for UdpServer::sendRequest 2016-08-03 14:48:10 +02:00
4e4e3371e6 Log function will now return void instead of a boolean 2016-08-01 18:12:10 +02:00
44df65c40b Use %02x instead of %hx for msgType 2016-07-26 17:21:35 +02:00
f9d9334d99 Remove commented out code and unused variable 2016-07-26 09:08:44 +02:00
5f14fb2cee More msgType changes 2016-07-25 16:00:36 +02:00
1ce5b59670 Code style changes. More changes of hardcoded msg_type_t value to enum. Log levels. 2016-07-25 15:13:03 +02:00
970c04ba05 Change log level 2016-07-25 15:13:03 +02:00
bde87ec9a3 Modify hardcoded msg type to a proper msg_type_t enum 2016-07-25 15:13:03 +02:00