Files
rust_browser/tests/goldens/expected/114-float-with-margin.layout.txt
Zachary D. Rowitsch b9380a8a03
All checks were successful
ci / fast (linux) (push) Successful in 6m43s
Fix inline line box height inflation that broke float two-column layouts
The strut half-leading calculation in apply_vertical_align used the
effective line height (inflated by tall inline-block elements like images)
instead of the CSS computed line-height. For a line with a 76px image and
CSS line-height: 15px, the strut got half_leading = (76 - font_height)/2
≈ 30, inflating descent by ~30px. This caused floated containers to
overflow their parents, leaking through shared BFC float contexts and
displacing sibling floats.

Fixes: pass CSS computed line-height separately for strut calculation;
also pass parent font family/weight/style for accurate strut metrics.
Adds float=left/right annotations to layout tree dumps for debugging.

32 WPT tests promoted from known_fail to pass. BMOW page sidebar moves
from x=73 to x=829 (correct float:right), content from y=4375 to y=114.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-15 02:36:00 -04:00

36 lines
1.4 KiB
Plaintext

LayoutBox node=#1 tag=html box=block
content: (0, 0, 800, 78)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
LayoutBox node=#8 tag=body box=block
content: (8, 8, 784, 39.2)
padding: 0 0 0 0
border: 0 0 0 0
margin: 8 8 8 8
LayoutBox node=#10 tag=div box=block float=left
content: (28, 18, 100, 50)
padding: 0 0 0 0
border: 0 0 0 0
margin: 10 20 10 20
inline_context: 0 lines, height=0, max_width=0
LayoutBox node=#12 tag=div box=block
content: (18, 18, 764, 19.2)
padding: 10 10 10 10
border: 0 0 0 0
margin: 0 0 0 0
inline_context: 1 lines, height=19.2, max_width=196.9339
line[0]: rect=(148, 18, 196.9339, 19.2) fragments=6
frag[0]: rect=(148, 19.6, 23.612333, 16) text="Text" start=false end=false
frag[1]: rect=(174.66667, 19.6, 29.039646, 16) text="flows" start=false end=false
frag[2]: rect=(206.76065, 19.6, 40.293686, 16) text="around" start=false end=false
frag[3]: rect=(250.10867, 19.6, 25.010277, 16) text="float" start=false end=false
frag[4]: rect=(278.17328, 19.6, 23.765053, 16) text="with" start=false end=false
frag[5]: rect=(304.99265, 19.6, 39.94126, 16) text="margin" start=false end=false
LayoutBox node=#13 tag=anonymous box=anon
content: (0, 0, 196.93391, 16)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: "Text flows around fl..."