Files
rust_browser/tests/goldens/expected/118-float-with-clear-on-float.layout.txt
Zachary D. Rowitsch b9380a8a03
All checks were successful
ci / fast (linux) (push) Successful in 6m43s
Fix inline line box height inflation that broke float two-column layouts
The strut half-leading calculation in apply_vertical_align used the
effective line height (inflated by tall inline-block elements like images)
instead of the CSS computed line-height. For a line with a 76px image and
CSS line-height: 15px, the strut got half_leading = (76 - font_height)/2
≈ 30, inflating descent by ~30px. This caused floated containers to
overflow their parents, leaking through shared BFC float contexts and
displacing sibling floats.

Fixes: pass CSS computed line-height separately for strut calculation;
also pass parent font family/weight/style for accurate strut metrics.
Adds float=left/right annotations to layout tree dumps for debugging.

32 WPT tests promoted from known_fail to pass. BMOW page sidebar moves
from x=73 to x=829 (correct float:right), content from y=4375 to y=114.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-15 02:36:00 -04:00

54 lines
1.8 KiB
Plaintext

LayoutBox node=#1 tag=html box=block
content: (0, 0, 800, 98)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
LayoutBox node=#8 tag=body box=block
content: (8, 8, 784, 0)
padding: 0 0 0 0
border: 0 0 0 0
margin: 8 8 8 8
inline_context: 0 lines, height=0, max_width=0
LayoutBox node=#9 tag=anonymous box=anon
content: (0, 0, 3.0543318, 16)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: " "
LayoutBox node=#10 tag=div box=block float=left
content: (8, 8, 100, 50)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
inline_context: 0 lines, height=0, max_width=0
LayoutBox node=#11 tag=anonymous box=anon
content: (0, 0, 3.0543318, 16)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: " "
LayoutBox node=#12 tag=div box=block float=left
content: (8, 58, 120, 40)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
inline_context: 2 lines, height=38.4, max_width=98.24375
line[0]: rect=(8, 58, 98.24375, 19.2) fragments=3
frag[0]: rect=(8, 59.6, 40.305435, 16) text="Second" start=false end=false
frag[1]: rect=(51.359768, 59.6, 25.010277, 16) text="float" start=false end=false
frag[2]: rect=(79.42437, 59.6, 23.765053, 16) text="with" start=false end=false
line[1]: rect=(8, 77.2, 47.823788, 19.2) fragments=1
frag[0]: rect=(8, 78.8, 47.823788, 16) text="clear:left" start=false end=false
LayoutBox node=#13 tag=anonymous box=anon
content: (0, 50, 146.06757, 16)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: "Second float with cl..."
LayoutBox node=#14 tag=anonymous box=anon
content: (0, 0, 3.0543318, 16)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: " "