Files
rust_browser/tests/goldens/expected/124-float-clear-right.layout.txt
Zachary D. Rowitsch b9380a8a03
All checks were successful
ci / fast (linux) (push) Successful in 6m43s
Fix inline line box height inflation that broke float two-column layouts
The strut half-leading calculation in apply_vertical_align used the
effective line height (inflated by tall inline-block elements like images)
instead of the CSS computed line-height. For a line with a 76px image and
CSS line-height: 15px, the strut got half_leading = (76 - font_height)/2
≈ 30, inflating descent by ~30px. This caused floated containers to
overflow their parents, leaking through shared BFC float contexts and
displacing sibling floats.

Fixes: pass CSS computed line-height separately for strut calculation;
also pass parent font family/weight/style for accurate strut metrics.
Adds float=left/right annotations to layout tree dumps for debugging.

32 WPT tests promoted from known_fail to pass. BMOW page sidebar moves
from x=73 to x=829 (correct float:right), content from y=4375 to y=114.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-15 02:36:00 -04:00

58 lines
2.7 KiB
Plaintext

LayoutBox node=#1 tag=html box=block
content: (0, 0, 800, 123.2)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
LayoutBox node=#8 tag=body box=block
content: (8, 16, 784, 99.2)
padding: 0 0 0 0
border: 0 0 0 0
margin: 8 8 8 8
LayoutBox node=#10 tag=div box=block float=right
content: (642, 16, 150, 60)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
inline_context: 0 lines, height=0, max_width=0
LayoutBox node=#12 tag=p box=block
content: (8, 16, 784, 19.2)
padding: 0 0 0 0
border: 0 0 0 0
margin: 16 0 16 0
inline_context: 1 lines, height=19.2, max_width=146.58441
line[0]: rect=(8, 16, 146.58441, 19.2) fragments=6
frag[0]: rect=(8, 17.6, 31.165932, 16) text="Some" start=false end=false
frag[1]: rect=(42.220264, 17.6, 21.321585, 16) text="text" start=false end=false
frag[2]: rect=(66.596176, 17.6, 24.340675, 16) text="next" start=false end=false
frag[3]: rect=(93.99118, 17.6, 11.348018, 16) text="to" start=false end=false
frag[4]: rect=(108.393524, 17.6, 18.126286, 16) text="the" start=false end=false
frag[5]: rect=(129.57414, 17.6, 25.010277, 16) text="float" start=false end=false
LayoutBox node=#13 tag=anonymous box=anon
content: (0, -8, 146.58441, 16)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: "Some text next to th..."
LayoutBox node=#15 tag=div box=block
content: (18, 86, 764, 19.199997)
padding: 10 10 10 10
border: 0 0 0 0
margin: 0 0 0 0
inline_context: 1 lines, height=19.199997, max_width=255.29517
line[0]: rect=(18, 86, 255.29517, 19.2) fragments=9
frag[0]: rect=(18, 87.6, 22.449337, 16) text="This" start=false end=false
frag[1]: rect=(43.50367, 87.6, 32.36417, 16) text="clears" start=false end=false
frag[2]: rect=(78.92217, 87.6, 18.126286, 16) text="the" start=false end=false
frag[3]: rect=(100.10279, 87.6, 26.60793, 16) text="right" start=false end=false
frag[4]: rect=(129.76506, 87.6, 25.010277, 16) text="float" start=false end=false
frag[5]: rect=(157.82967, 87.6, 21.07489, 16) text="and" start=false end=false
frag[6]: rect=(181.9589, 87.6, 44.73421, 16) text="appears" start=false end=false
frag[7]: rect=(229.74744, 87.6, 33.221733, 16) text="below" start=false end=false
frag[8]: rect=(266.0235, 87.6, 7.2716594, 16) text="it" start=false end=false
LayoutBox node=#16 tag=anonymous box=anon
content: (0, 8, 255.29514, 16)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: "This clears the righ..."