moldybits/rust_browser
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
fix/es-modules-fifth-review-3-4
rust_browser/tests/goldens/expected/180-absolute-shrink-to-fit.layout.txt
Zachary D. Rowitsch b9380a8a03
All checks were successful
ci / fast (linux) (push) Successful in 6m43s
Details
Fix inline line box height inflation that broke float two-column layouts 
The strut half-leading calculation in apply_vertical_align used the
effective line height (inflated by tall inline-block elements like images)
instead of the CSS computed line-height. For a line with a 76px image and
CSS line-height: 15px, the strut got half_leading = (76 - font_height)/2
≈ 30, inflating descent by ~30px. This caused floated containers to
overflow their parents, leaking through shared BFC float contexts and
displacing sibling floats.

Fixes: pass CSS computed line-height separately for strut calculation;
also pass parent font family/weight/style for accurate strut metrics.
Adds float=left/right annotations to layout tree dumps for debugging.

32 WPT tests promoted from known_fail to pass. BMOW page sidebar moves
from x=73 to x=829 (correct float:right), content from y=4375 to y=114.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-15 02:36:00 -04:00

209 lines
6.6 KiB
Plaintext
Raw Permalink Blame History

LayoutBox node=#1 tag=html box=block
content: (0, 0, 800, 2100)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
LayoutBox node=#8 tag=body box=block
content: (0, 0, 800, 2100)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
LayoutBox node=#12 tag=div box=block
content: (0, 0, 400, 300)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
LayoutBox node=#14 tag=div box=block
content: (0, 0, 80.015625, 0)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
inline_context: 0 lines, height=0, max_width=0
LayoutBox node=#15 tag=anonymous box=anon
content: (0, 0, 0, 0)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: " "
LayoutBox node=#16 tag=div box=block float=left
content: (0, 0, 80, 20)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
inline_context: 0 lines, height=0, max_width=0
LayoutBox node=#17 tag=anonymous box=anon
content: (0, 0, 0, 0)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: " "
LayoutBox node=#22 tag=div box=block
content: (0, 300, 400, 300)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
LayoutBox node=#24 tag=div box=block
content: (20, 300, 80.015625, 0)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
inline_context: 0 lines, height=0, max_width=0
LayoutBox node=#25 tag=anonymous box=anon
content: (0, 0, 0, 0)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: " "
LayoutBox node=#26 tag=div box=block float=left
content: (20, 300, 80, 20)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
inline_context: 0 lines, height=0, max_width=0
LayoutBox node=#27 tag=anonymous box=anon
content: (0, 0, 0, 0)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: " "
LayoutBox node=#32 tag=div box=block
content: (0, 600, 400, 300)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
LayoutBox node=#34 tag=div box=block
content: (299.98438, 600, 80.015625, 0)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
inline_context: 0 lines, height=0, max_width=0
LayoutBox node=#35 tag=anonymous box=anon
content: (0, 0, 0, 0)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: " "
LayoutBox node=#36 tag=div box=block float=left
content: (299.98438, 600, 80, 20)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
inline_context: 0 lines, height=0, max_width=0
LayoutBox node=#37 tag=anonymous box=anon
content: (0, 0, 0, 0)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: " "
LayoutBox node=#42 tag=div box=block
content: (0, 900, 400, 300)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
LayoutBox node=#44 tag=div box=block
content: (20, 900, 360, 0)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
inline_context: 0 lines, height=0, max_width=0
LayoutBox node=#45 tag=anonymous box=anon
content: (0, 0, 3.0543318, 16)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: " "
LayoutBox node=#46 tag=div box=block float=left
content: (20, 900, 80, 20)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
inline_context: 0 lines, height=0, max_width=0
LayoutBox node=#47 tag=anonymous box=anon
content: (0, 0, 3.0543318, 16)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: " "
LayoutBox node=#52 tag=div box=block
content: (0, 1200, 400, 300)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
LayoutBox node=#54 tag=div box=block
content: (0, 1200, 150, 0)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
inline_context: 0 lines, height=0, max_width=0
LayoutBox node=#55 tag=anonymous box=anon
content: (0, 0, 3.0543318, 16)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: " "
LayoutBox node=#56 tag=div box=block float=left
content: (0, 1200, 80, 20)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
inline_context: 0 lines, height=0, max_width=0
LayoutBox node=#57 tag=anonymous box=anon
content: (0, 0, 3.0543318, 16)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: " "
LayoutBox node=#62 tag=div box=block
content: (0, 1500, 400, 300)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
LayoutBox node=#64 tag=div box=block
content: (0, 1500, 80.015625, 0)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
inline_context: 0 lines, height=0, max_width=0
LayoutBox node=#65 tag=anonymous box=anon
content: (0, 0, 0, 0)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: " "
LayoutBox node=#66 tag=div box=block float=left
content: (0, 1500, 80, 20)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
inline_context: 0 lines, height=0, max_width=0
LayoutBox node=#67 tag=anonymous box=anon
content: (0, 0, 0, 0)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: " "
LayoutBox node=#72 tag=div box=block
content: (0, 1800, 400, 300)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
inline_context: 0 lines, height=0, max_width=0
LayoutBox node=#73 tag=anonymous box=anon
content: (0, 0, 3.0543318, 16)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: " "
LayoutBox node=#74 tag=img box=inline
content: (0, 1800, 60, 40)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
inline_context: 0 lines, height=0, max_width=0
LayoutBox node=#75 tag=anonymous box=anon
content: (0, 0, 3.0543318, 16)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: " "
Reference in New Issue View Git Blame Copy Permalink