Files
rust_browser/tests/goldens/expected/172-line-height-var.layout.txt
Zachary D. Rowitsch 20e241bd03
All checks were successful
ci / fast (linux) (push) Successful in 6m52s
Implement margin collapsing through empty elements (CSS 2.1 §8.3.1)
Self-collapsing elements (zero height, no padding/border, no BFC, no line
boxes) now have their top and bottom margins collapse together, and child
margins propagate through parents with auto height and no bottom
padding/border. This replaces the pairwise collapse_margins() function
with a MarginSet accumulator that tracks max positive and min negative
margins separately, correctly resolving chains of 4+ margins.

Key changes:
- Add is_self_collapsing() post-layout predicate and gather_all_margins()
- Add gather_margin_bottom() for bottom margin propagation with a guard
  against propagation when max-height constrains the parent
- Replace prev_margin_bottom with MarginSet-based pending_margins in the
  sibling layout loop
- Handle clearance + self-collapsing interaction correctly

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-01 01:04:53 -05:00

35 lines
1.7 KiB
Plaintext

LayoutBox node=#2 tag=html box=block
content: (0, 0, 800, 107.2)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
LayoutBox node=#10 tag=body box=block
content: (8, 8, 784, 83.2)
padding: 0 0 0 0
border: 0 0 0 0
margin: 8 8 8 8
LayoutBox node=#12 tag=p box=block
content: (8, 24, 200, 51.199997)
padding: 0 0 0 0
border: 0 0 0 0
margin: 16 0 16 0
inline_context: 2 lines, height=51.199997, max_width=196.56978
line[0]: rect=(8, 24, 196.56978, 25.6) fragments=8
frag[0]: rect=(8, 28.8, 23.847282, 16) text="First" start=false end=false
frag[1]: rect=(34.901615, 28.8, 19.947138, 16) text="line" start=false end=false
frag[2]: rect=(57.903088, 28.8, 11.148312, 16) text="of" start=false end=false
frag[3]: rect=(72.10573, 28.8, 24.469896, 16) text="text." start=false end=false
frag[4]: rect=(99.62995, 28.8, 40.305435, 16) text="Second" start=false end=false
frag[5]: rect=(142.98973, 28.8, 19.947138, 16) text="line" start=false end=false
frag[6]: rect=(165.99121, 28.8, 11.148312, 16) text="of" start=false end=false
frag[7]: rect=(180.19386, 28.8, 21.321585, 16) text="text" start=false end=false
line[1]: rect=(8, 49.6, 62.061676, 25.6) fragments=2
frag[0]: rect=(8, 54.399998, 22.331863, 16) text="that" start=false end=false
frag[1]: rect=(33.386196, 54.399998, 36.675476, 16) text="wraps." start=false end=false
LayoutBox node=#13 tag=anonymous box=anon
content: (0, 0, 258.63144, 16)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: "First line of text. ..."