Removed default parameter values from Msg5::getList() (variant )

This commit is contained in:
Ivan Skytte Jørgensen
2016-08-01 13:34:10 +02:00
parent 1637bdf08f
commit d6796099bb
9 changed files with 111 additions and 39 deletions

@ -210,12 +210,14 @@ bool Linkdb::verify ( char *coll ) {
NULL , // callback
0 , // niceness
false , // err correction?
NULL ,
0 ,
-1 ,
true ,
-1LL ,
true )) {
NULL , // cacheKey
0 , // retryNum
-1 , // maxRetries
true , // compensateForMerge
-1LL , // syncPoint
true , // isRealMerge
true)) // allowPageCache
{
g_jobScheduler.allow_new_jobs();
return log("db: HEY! it did not block");
}
@ -1096,7 +1098,15 @@ bool Msg25::doReadLoop ( ) {
this ,
gotListWrapper ,
m_niceness ,
true )){ // error correct?
true , // error correct?
NULL, //cachekey
0, //retryNum
-1, //maxRetries
true, //comp-for-merge
-1, //syncPoint
false, //isRealMerge
true)) //allowPageCache
{
//log("debug: msg0 blocked this=%" PRIx32,(int32_t)this);
return false;
}

14
Msg5.h

@ -51,13 +51,13 @@ class Msg5 {
void (* callback ) ( void *state, RdbList *list, Msg5 *msg5 ),
int32_t niceness ,
bool doErrorCorrection ,
char *cacheKeyPtr = NULL ,
int32_t retryNum = 0 ,
int32_t maxRetries = -1 ,
bool compensateForMerge = true ,
int64_t syncPoint = -1 ,
bool isRealMerge = false ,
bool allowPageCache = true );
char *cacheKeyPtr,
int32_t retryNum,
int32_t maxRetries,
bool compensateForMerge,
int64_t syncPoint,
bool isRealMerge,
bool allowPageCache);
bool getList ( char rdbId ,
collnum_t collnum ,

@ -2271,12 +2271,13 @@ bool RdbBase::verifyFileSharding ( ) {
NULL , // callback
0 , // niceness
false , // err correction?
NULL ,
0 ,
-1 ,
true ,
-1LL ,
true )) {
NULL , // cachekey
0 , // retryNum
-1 , // maxRetries
true , // compenstateForMerge
-1LL , // syncPint
true , // isRealMerge
true)) { // allowPageCache
g_jobScheduler.allow_new_jobs();
log( LOG_DEBUG, "db: HEY! it did not block");
return false;

@ -411,7 +411,9 @@ bool Rebalance::scanRdb ( ) {
0 , // retry num
-1 , // maxRetries
true , // compensate for merge
-1LL )) // sync point
-1LL , // sync point
false, // isRealMerge
true)) // allowPageCache
return false;
//

@ -593,12 +593,13 @@ bool Spiderdb::verify ( char *coll ) {
NULL , // callback
0 , // niceness
false , // err correction?
NULL ,
0 ,
-1 ,
true ,
-1LL ,
true )) {
NULL , // cache key
0 , // retryNum
-1 , // maxRetries
true , // compenstateForMerge
-1LL , // syncPoint
true , // isRealMerge
true )) { // allowPageCache
g_jobScheduler.allow_new_jobs();
return log("db: HEY! it did not block");
}

@ -246,7 +246,10 @@ bool SpiderColl::makeDoleIPTable ( ) {
0 , // retry num
-1 , // maxRetries
true , // compensate for merge
-1LL )){ // sync point
-1LL , // sync point
false, // isRealMerge
true)) // allowPageCache
{
log(LOG_LOGIC,"spider: getList did not block.");
return false;
}
@ -341,7 +344,10 @@ bool SpiderColl::makeWaitingTree ( ) {
0 , // retry num
-1 , // maxRetries
true , // compensate for merge
-1LL )){ // sync point
-1LL , // sync point
false, // isRealMerge
true)) // allowPageCache
{
log(LOG_LOGIC,"spider: getList did not block.");
return false;
}
@ -1543,7 +1549,14 @@ void SpiderColl::populateWaitingTreeFromSpiderdb ( bool reentry ) {
this,//(void *)state2,//this//state
gotSpiderdbListWrapper2 ,
MAX_NICENESS , // niceness
true )) // do error correct?
true , // do error correct?
NULL, // cachekey
0, // retryNum
-1, // maxRetries
true, // compensateForMerge
-1, // syncPoint
false, // isRealMerge
true)) // allowPageCache
{
// return if blocked
logTrace( g_conf.m_logTraceSpider, "END, msg5b.getList blocked" );
@ -2462,7 +2475,14 @@ bool SpiderColl::readListFromSpiderdb ( ) {
this,//(void *)state2,//this,//state
gotSpiderdbListWrapper ,
MAX_NICENESS , // niceness
true )) // do error correct?
true, // do error correct?
NULL, // cachekey
0, // retryNum
-1, // maxRetries
true, // compensateForMerge
-1, // syncPoint
false, // isRealMerge
true )) // allowPageCache
{
// return false if blocked
logTrace( g_conf.m_logTraceSpider, "END, msg5.getList blocked" );

@ -590,7 +590,9 @@ bool Statsdb::gifLoop ( ) {
0 , // # retries
-1 , // max # retries
true , // compensate for merge?
-1 ) ) // sync point
-1 , // sync point
false, // isRealMerge
true)) // allowPageCache
return false;
// . process list
// . returns false with g_errno set on error

@ -1115,8 +1115,10 @@ bool Tagdb::verify ( const char *coll ) {
0 ,
-1 ,
true ,
-1LL ,
true )) {
-1LL , // syncPoint
true , // isRealMerge
true)) // allowPageCache
{
g_jobScheduler.allow_new_jobs();
return log("tagdb: HEY! it did not block");
}

@ -3398,7 +3398,15 @@ int32_t dumpSpiderdb ( const char *coll, int32_t startFileNum, int32_t numFiles,
NULL , // state
NULL , // callback
0 , // niceness
false )){// err correction?
false , // err correction?
NULL, // cacheKeyPtr
0, // retryNum
-1, // maxRetries
true, // compensateForMerge
-1, // syncPoint
false, // isRealMerge
true)) // allowPageCache
{
log(LOG_LOGIC,"db: getList did not block.");
return -1;
}
@ -4101,7 +4109,15 @@ void dumpTagdb( const char *coll, int32_t startFileNum, int32_t numFiles, bool i
NULL , // state
NULL , // callback
0 , // niceness
false )){// err correction?
false , // err correction?
NULL, // cacheKeyPtr
0, // retryNum
-1, // maxRetries
true, // compensateForMerge
-1, // syncPoint
false, // isRealMerge
true)) // allowPageCache
{
log(LOG_LOGIC,"db: getList did not block.");
return;
}
@ -4633,7 +4649,15 @@ void dumpPosdb (const char *coll, int32_t startFileNum, int32_t numFiles, bool i
NULL , // state
NULL , // callback
0 , // niceness
true )) { // to debug RdbList::removeBadData_r()
true, // to debug RdbList::removeBadData_r()
NULL, // cacheKeyPtr
0, // retryNum
-1, // maxRetries
true, // compensateForMerge
-1, // syncPoint
false, // isRealMerge
true)) // allowPageCache
{
//false )){// err correction?
log(LOG_LOGIC,"db: getList did not block.");
return;
@ -4915,7 +4939,15 @@ void dumpLinkdb ( const char *coll,
NULL , // state
NULL , // callback
0 , // niceness
false )){// err correction?
false , // err correction?
NULL, // cacheKeyPtr
0, // retryNum
-1, // maxRetries
true, // compensateForMerge
-1, // syncPoint
false, // isRealMerge
true)) // allowPageCache
{
log(LOG_LOGIC,"db: getList did not block.");
return;
}
@ -5499,7 +5531,9 @@ void doInject ( int fd , void *state ) {
0 , // retry num
-1 , // maxRetries
true , // compensate for merge
-1LL ); // sync point
-1LL, // sync point
false, // isRealMerge
true); // allowPageCache
// all done if empty
if ( list.isEmpty() ) { g_loop.reset(); exit(0); }
// loop over entries in list