Repos/openvistapro
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: add ASCII grid importer #6

Merged
moldybits merged 1 commits from feat/ascii-grid-importer-open into main 2026-05-16 13:52:31 -04:00
Conversation 0 Commits 1 Files Changed 4
+252 -3
moldybot commented 2026-05-15 20:56:05 -04:00
Member
Copy Link
Copy Source

Summary

  • add an ascii-grid-import Cargo feature for ESRI ASCII Grid parsing
  • document the parser in the import module and advertise it in info output when the feature is enabled
  • add tiny project-owned ESRI ASCII grid fixture and parser tests for valid import, malformed headers, sample counts, and min/max

Test plan

  • cargo fmt --check
  • cargo test import
  • cargo test --features ascii-grid-import import
  • cargo test
  • cargo test --features ascii-grid-import
  • cargo clippy --all-targets -- -D warnings
  • cargo clippy --features ascii-grid-import --all-targets -- -D warnings
  • cargo run --features ascii-grid-import --bin openvistapro -- info

Notes

  • This branch is stacked on the terrain import abstraction commit from the prior task because the original base branch was no longer present on the remote when opening this PR.
  • Merged origin/main after PR creation; PR #6 is mergeable.
## Summary - add an ascii-grid-import Cargo feature for ESRI ASCII Grid parsing - document the parser in the import module and advertise it in info output when the feature is enabled - add tiny project-owned ESRI ASCII grid fixture and parser tests for valid import, malformed headers, sample counts, and min/max ## Test plan - cargo fmt --check - cargo test import - cargo test --features ascii-grid-import import - cargo test - cargo test --features ascii-grid-import - cargo clippy --all-targets -- -D warnings - cargo clippy --features ascii-grid-import --all-targets -- -D warnings - cargo run --features ascii-grid-import --bin openvistapro -- info ## Notes - This branch is stacked on the terrain import abstraction commit from the prior task because the original base branch was no longer present on the remote when opening this PR. - Merged origin/main after PR creation; PR #6 is mergeable.
moldybot force-pushed feat/ascii-grid-importer-open from d572c295a9 to 4686ac7f2a 2026-05-16 10:41:49 -04:00 Compare
moldybot added 1 commit 2026-05-16 13:51:44 -04:00
feat: add feature-gated ESRI ASCII grid importer 87a6c91ad7
moldybot force-pushed feat/ascii-grid-importer-open from 4686ac7f2a to 87a6c91ad7 2026-05-16 13:51:44 -04:00 Compare
moldybits merged commit 87a6c91ad7 into main 2026-05-16 13:52:31 -04:00
moldybits deleted branch feat/ascii-grid-importer-open 2026-05-16 13:52:32 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
moldybits moldybot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Repos/openvistapro#6
Delete Branch "feat/ascii-grid-importer-open"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?