add Constructive Solid Geometry support #11

2020-10-04T20:26:34-04:00

twistdroach commented

2020-10-04 20:26:34 -04:00

(Migrated from github.com)

No description provided.

codecov[bot] commented

2020-10-04 20:27:57 -04:00

(Migrated from github.com)

Codecov Report

Merging #11 into master will decrease coverage by 0.06%.
The diff coverage is 81.67%.

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   91.50%   91.44%   -0.07%     
==========================================
  Files          47       49       +2     
  Lines        4544     4732     +188     
==========================================
+ Hits         4158     4327     +169     
- Misses        386      405      +19

Impacted Files	Coverage Δ
module_shapes/cone.c	`0.00% <ø> (ø)`
module_shapes/cube.c	`100.00% <ø> (ø)`
module_shapes/cylinder.c	`87.87% <ø> (ø)`
module_shapes/group.c	`70.96% <0.00%> (-10.52%)`	⬇️
module_shapes/plane.c	`100.00% <ø> (ø)`
module_shapes/sphere.c	`100.00% <ø> (ø)`
module_shapes/testshape.c	`94.73% <ø> (ø)`
module_shapes/triangle.c	`92.95% <ø> (ø)`
module_datastructures/arrlist.c	`89.36% <25.00%> (-6.10%)`	⬇️
module_shapes/csg.c	`68.57% <68.57%> (ø)`
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3ecba7...e7e9a85. Read the comment docs.

# [Codecov](https://codecov.io/gh/twistdroach/raytracer-c/pull/11?src=pr&el=h1) Report > Merging [#11](https://codecov.io/gh/twistdroach/raytracer-c/pull/11?src=pr&el=desc) into [master](https://codecov.io/gh/twistdroach/raytracer-c/commit/e3ecba7b84bf5b75336c7ff4afb6c0ac56df5397?el=desc) will **decrease** coverage by `0.06%`. > The diff coverage is `81.67%`. [![Impacted file tree graph](https://codecov.io/gh/twistdroach/raytracer-c/pull/11/graphs/tree.svg?width=650&height=150&src=pr&token=Z7FHFD9D2J)](https://codecov.io/gh/twistdroach/raytracer-c/pull/11?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #11 +/- ## ========================================== - Coverage 91.50% 91.44% -0.07% ========================================== Files 47 49 +2 Lines 4544 4732 +188 ========================================== + Hits 4158 4327 +169 - Misses 386 405 +19 ``` | [Impacted Files](https://codecov.io/gh/twistdroach/raytracer-c/pull/11?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [module\_shapes/cone.c](https://codecov.io/gh/twistdroach/raytracer-c/pull/11/diff?src=pr&el=tree#diff-bW9kdWxlX3NoYXBlcy9jb25lLmM=) | `0.00% <ø> (ø)` | | | [module\_shapes/cube.c](https://codecov.io/gh/twistdroach/raytracer-c/pull/11/diff?src=pr&el=tree#diff-bW9kdWxlX3NoYXBlcy9jdWJlLmM=) | `100.00% <ø> (ø)` | | | [module\_shapes/cylinder.c](https://codecov.io/gh/twistdroach/raytracer-c/pull/11/diff?src=pr&el=tree#diff-bW9kdWxlX3NoYXBlcy9jeWxpbmRlci5j) | `87.87% <ø> (ø)` | | | [module\_shapes/group.c](https://codecov.io/gh/twistdroach/raytracer-c/pull/11/diff?src=pr&el=tree#diff-bW9kdWxlX3NoYXBlcy9ncm91cC5j) | `70.96% <0.00%> (-10.52%)` | :arrow_down: | | [module\_shapes/plane.c](https://codecov.io/gh/twistdroach/raytracer-c/pull/11/diff?src=pr&el=tree#diff-bW9kdWxlX3NoYXBlcy9wbGFuZS5j) | `100.00% <ø> (ø)` | | | [module\_shapes/sphere.c](https://codecov.io/gh/twistdroach/raytracer-c/pull/11/diff?src=pr&el=tree#diff-bW9kdWxlX3NoYXBlcy9zcGhlcmUuYw==) | `100.00% <ø> (ø)` | | | [module\_shapes/testshape.c](https://codecov.io/gh/twistdroach/raytracer-c/pull/11/diff?src=pr&el=tree#diff-bW9kdWxlX3NoYXBlcy90ZXN0c2hhcGUuYw==) | `94.73% <ø> (ø)` | | | [module\_shapes/triangle.c](https://codecov.io/gh/twistdroach/raytracer-c/pull/11/diff?src=pr&el=tree#diff-bW9kdWxlX3NoYXBlcy90cmlhbmdsZS5j) | `92.95% <ø> (ø)` | | | [module\_datastructures/arrlist.c](https://codecov.io/gh/twistdroach/raytracer-c/pull/11/diff?src=pr&el=tree#diff-bW9kdWxlX2RhdGFzdHJ1Y3R1cmVzL2Fycmxpc3QuYw==) | `89.36% <25.00%> (-6.10%)` | :arrow_down: | | [module\_shapes/csg.c](https://codecov.io/gh/twistdroach/raytracer-c/pull/11/diff?src=pr&el=tree#diff-bW9kdWxlX3NoYXBlcy9jc2cuYw==) | `68.57% <68.57%> (ø)` | | | ... and [7 more](https://codecov.io/gh/twistdroach/raytracer-c/pull/11/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/twistdroach/raytracer-c/pull/11?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/twistdroach/raytracer-c/pull/11?src=pr&el=footer). Last update [e3ecba7...e7e9a85](https://codecov.io/gh/twistdroach/raytracer-c/pull/11?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lgtm-com[bot] commented

2020-10-04 20:30:28 -04:00

(Migrated from github.com)

This pull request introduces 1 alert when merging e7e9a85f77 into e3ecba7b84 - view on LGTM.com

new alerts:

1 for Short global name

This pull request **introduces 1 alert** when merging e7e9a85f77db7971d4634bd771872e68c1422256 into e3ecba7b84bf5b75336c7ff4afb6c0ac56df5397 - [view on LGTM.com](https://lgtm.com/projects/g/twistdroach/raytracer-c/rev/pr-e2e9effbb93a00f987c62965406cce4e517bba6a) **new alerts:** * 1 for Short global name

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: moldybits/raytracer-c#11