Files
rust_browser/tests/goldens/expected/112-float-inline-wrap.layout.txt
Zachary D. Rowitsch b9380a8a03
All checks were successful
ci / fast (linux) (push) Successful in 6m43s
Fix inline line box height inflation that broke float two-column layouts
The strut half-leading calculation in apply_vertical_align used the
effective line height (inflated by tall inline-block elements like images)
instead of the CSS computed line-height. For a line with a 76px image and
CSS line-height: 15px, the strut got half_leading = (76 - font_height)/2
≈ 30, inflating descent by ~30px. This caused floated containers to
overflow their parents, leaking through shared BFC float contexts and
displacing sibling floats.

Fixes: pass CSS computed line-height separately for strut calculation;
also pass parent font family/weight/style for accurate strut metrics.
Adds float=left/right annotations to layout tree dumps for debugging.

32 WPT tests promoted from known_fail to pass. BMOW page sidebar moves
from x=73 to x=829 (correct float:right), content from y=4375 to y=114.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-15 02:36:00 -04:00

40 lines
1.8 KiB
Plaintext

LayoutBox node=#1 tag=html box=block
content: (0, 0, 800, 67.2)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
LayoutBox node=#8 tag=body box=block
content: (8, 16, 784, 35.2)
padding: 0 0 0 0
border: 0 0 0 0
margin: 8 8 8 8
LayoutBox node=#10 tag=div box=block float=left
content: (8, 16, 200, 40)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
inline_context: 0 lines, height=0, max_width=0
LayoutBox node=#12 tag=p box=block
content: (8, 16, 784, 19.2)
padding: 0 0 0 0
border: 0 0 0 0
margin: 16 0 16 0
inline_context: 1 lines, height=19.2, max_width=277.28625
line[0]: rect=(208, 16, 277.28625, 19.2) fragments=10
frag[0]: rect=(208, 17.6, 29.908957, 16) text="Short" start=false end=false
frag[1]: rect=(240.96329, 17.6, 21.321585, 16) text="text" start=false end=false
frag[2]: rect=(265.3392, 17.6, 33.527164, 16) text="wraps" start=false end=false
frag[3]: rect=(301.9207, 17.6, 40.293686, 16) text="around" start=false end=false
frag[4]: rect=(345.26868, 17.6, 18.126286, 16) text="the" start=false end=false
frag[5]: rect=(366.44928, 17.6, 25.010277, 16) text="float" start=false end=false
frag[6]: rect=(394.5139, 17.6, 14.367107, 16) text="on" start=false end=false
frag[7]: rect=(411.9353, 17.6, 18.126286, 16) text="the" start=false end=false
frag[8]: rect=(433.1159, 17.6, 26.60793, 16) text="right" start=false end=false
frag[9]: rect=(462.77817, 17.6, 22.508076, 16) text="side" start=false end=false
LayoutBox node=#13 tag=anonymous box=anon
content: (0, -8, 277.2864, 16)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: "Short text wraps aro..."