Files
rust_browser/tests/goldens/expected/122-float-with-text-content.layout.txt
Zachary D. Rowitsch b9380a8a03
All checks were successful
ci / fast (linux) (push) Successful in 6m43s
Fix inline line box height inflation that broke float two-column layouts
The strut half-leading calculation in apply_vertical_align used the
effective line height (inflated by tall inline-block elements like images)
instead of the CSS computed line-height. For a line with a 76px image and
CSS line-height: 15px, the strut got half_leading = (76 - font_height)/2
≈ 30, inflating descent by ~30px. This caused floated containers to
overflow their parents, leaking through shared BFC float contexts and
displacing sibling floats.

Fixes: pass CSS computed line-height separately for strut calculation;
also pass parent font family/weight/style for accurate strut metrics.
Adds float=left/right annotations to layout tree dumps for debugging.

32 WPT tests promoted from known_fail to pass. BMOW page sidebar moves
from x=73 to x=829 (correct float:right), content from y=4375 to y=114.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-15 02:36:00 -04:00

51 lines
2.4 KiB
Plaintext

LayoutBox node=#1 tag=html box=block
content: (0, 0, 800, 47.2)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
LayoutBox node=#8 tag=body box=block
content: (8, 8, 784, 19.2)
padding: 0 0 0 0
border: 0 0 0 0
margin: 8 8 8 8
LayoutBox node=#10 tag=div box=block float=left
content: (18, 18, 120, 19.2)
padding: 10 10 10 10
border: 0 0 0 0
margin: 0 0 0 0
inline_context: 1 lines, height=19.2, max_width=111.13068
line[0]: rect=(18, 18, 111.13068, 19.2) fragments=4
frag[0]: rect=(18, 19.6, 23.612333, 16) text="Text" start=false end=false
frag[1]: rect=(44.666668, 19.6, 32.798824, 16) text="inside" start=false end=false
frag[2]: rect=(80.51982, 19.6, 25.010277, 16) text="float" start=false end=false
frag[3]: rect=(108.58443, 19.6, 20.546255, 16) text="box" start=false end=false
LayoutBox node=#11 tag=anonymous box=anon
content: (0, 0, 111.130684, 16)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: "Text inside float bo..."
LayoutBox node=#13 tag=div box=block
content: (8, 8, 784, 19.2)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
inline_context: 1 lines, height=19.2, max_width=315.88834
line[0]: rect=(148, 8, 315.88834, 19.2) fragments=10
frag[0]: rect=(148, 9.6, 27.535978, 16) text="Main" start=false end=false
frag[1]: rect=(178.59032, 9.6, 42.372982, 16) text="content" start=false end=false
frag[2]: rect=(224.01764, 9.6, 29.039646, 16) text="flows" start=false end=false
frag[3]: rect=(256.1116, 9.6, 40.293686, 16) text="around" start=false end=false
frag[4]: rect=(299.4596, 9.6, 18.126286, 16) text="the" start=false end=false
frag[5]: rect=(320.6402, 9.6, 25.010277, 16) text="float" start=false end=false
frag[6]: rect=(348.7048, 9.6, 32.42291, 16) text="which" start=false end=false
frag[7]: rect=(384.18204, 9.6, 19.477238, 16) text="has" start=false end=false
frag[8]: rect=(406.7136, 9.6, 21.321585, 16) text="text" start=false end=false
frag[9]: rect=(431.0895, 9.6, 32.798824, 16) text="inside" start=false end=false
LayoutBox node=#14 tag=anonymous box=anon
content: (0, 0, 315.88837, 16)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: "Main content flows a..."