Files
rust_browser/tests/goldens/expected/164-inline-flex.layout.txt
Zachary D. Rowitsch b9380a8a03
All checks were successful
ci / fast (linux) (push) Successful in 6m43s
Fix inline line box height inflation that broke float two-column layouts
The strut half-leading calculation in apply_vertical_align used the
effective line height (inflated by tall inline-block elements like images)
instead of the CSS computed line-height. For a line with a 76px image and
CSS line-height: 15px, the strut got half_leading = (76 - font_height)/2
≈ 30, inflating descent by ~30px. This caused floated containers to
overflow their parents, leaking through shared BFC float contexts and
displacing sibling floats.

Fixes: pass CSS computed line-height separately for strut calculation;
also pass parent font family/weight/style for accurate strut metrics.
Adds float=left/right annotations to layout tree dumps for debugging.

32 WPT tests promoted from known_fail to pass. BMOW page sidebar moves
from x=73 to x=829 (correct float:right), content from y=4375 to y=114.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-15 02:36:00 -04:00

70 lines
2.7 KiB
Plaintext

LayoutBox node=#1 tag=html box=block
content: (0, 0, 800, 161.442)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
LayoutBox node=#8 tag=body box=block
content: (8, 16, 784, 129.442)
padding: 0 0 0 0
border: 0 0 0 0
margin: 8 8 8 8
LayoutBox node=#10 tag=p box=block
content: (8, 16, 787.0543, 113.442)
padding: 0 0 0 0
border: 0 0 0 0
margin: 16 0 16 0
inline_context: 3 lines, height=113.442, max_width=787.0543
line[0]: rect=(8, 16, 66.19676, 19.2) fragments=2
frag[0]: rect=(8, 17.6, 23.612333, 16) text="Text" start=false end=false
frag[1]: rect=(34.666664, 17.6, 36.47577, 16) text="before" start=false end=false
line[1]: rect=(8, 35.2, 787.0543, 75.042) fragments=1
frag[0]: rect=(8, 35.2, 784, 70) text=(none) start=false end=false
line[2]: rect=(8, 110.242004, 50.725403, 19.2) fragments=2
frag[0]: rect=(8, 111.842, 21.321585, 16) text="text" start=false end=false
frag[1]: rect=(32.375916, 111.842, 26.349485, 16) text="after" start=false end=false
LayoutBox node=#11 tag=anonymous box=anon
content: (0, -8, 66.19676, 16)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: "Text before "
LayoutBox node=#12 tag=span box=flex
content: (18, 45.2, 764, 50)
padding: 10 10 10 10
border: 0 0 0 0
margin: 0 0 0 0
LayoutBox node=#13 tag=span box=block
content: (23, 50.2, 50, 40)
padding: 0 0 0 0
border: 0 0 0 0
margin: 5 5 5 5
inline_context: 1 lines, height=19.2, max_width=7.506607
line[0]: rect=(23, 50.2, 7.506607, 19.2) fragments=1
frag[0]: rect=(23, 51.8, 7.506608, 16) text="A" start=false end=false
LayoutBox node=#14 tag=anonymous box=anon
content: (0, 11.200001, 7.506608, 16)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: "A"
LayoutBox node=#15 tag=span box=block
content: (83, 50.2, 50, 40)
padding: 0 0 0 0
border: 0 0 0 0
margin: 5 5 5 5
inline_context: 1 lines, height=19.2, max_width=7.635826
line[0]: rect=(83, 50.2, 7.635826, 19.2) fragments=1
frag[0]: rect=(83, 51.8, 7.6358294, 16) text="B" start=false end=false
LayoutBox node=#16 tag=anonymous box=anon
content: (0, 11.200001, 7.6358294, 16)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: "B"
LayoutBox node=#17 tag=anonymous box=anon
content: (0, -8, 53.77973, 16)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: " text after"