Files
rust_browser/tests/goldens/expected/293-img-aspect-ratio-max-width.layout.txt
Zachary D. Rowitsch b9380a8a03
All checks were successful
ci / fast (linux) (push) Successful in 6m43s
Fix inline line box height inflation that broke float two-column layouts
The strut half-leading calculation in apply_vertical_align used the
effective line height (inflated by tall inline-block elements like images)
instead of the CSS computed line-height. For a line with a 76px image and
CSS line-height: 15px, the strut got half_leading = (76 - font_height)/2
≈ 30, inflating descent by ~30px. This caused floated containers to
overflow their parents, leaking through shared BFC float contexts and
displacing sibling floats.

Fixes: pass CSS computed line-height separately for strut calculation;
also pass parent font family/weight/style for accurate strut metrics.
Adds float=left/right annotations to layout tree dumps for debugging.

32 WPT tests promoted from known_fail to pass. BMOW page sidebar moves
from x=73 to x=829 (correct float:right), content from y=4375 to y=114.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-15 02:36:00 -04:00

33 lines
1.0 KiB
Plaintext

LayoutBox node=#1 tag=html box=block
content: (0, 0, 800, 71.04199)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
LayoutBox node=#3 tag=body box=block
content: (8, 8, 784, 55.041996)
padding: 0 0 0 0
border: 0 0 0 0
margin: 8 8 8 8
inline_context: 1 lines, height=55.041996, max_width=53.054333
line[0]: rect=(8, 8, 53.054333, 55.041996) fragments=1
frag[0]: rect=(8, 8, 50, 50) text=(none) start=false end=false
LayoutBox node=#4 tag=anonymous box=anon
content: (0, 0, 3.0543318, 16)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: " "
LayoutBox node=#5 tag=img box=inline-block
content: (8, 8, 50, 50)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
image: img#0 (intrinsic: 100x50)
inline_context: 0 lines, height=0, max_width=0
LayoutBox node=#6 tag=anonymous box=anon
content: (0, 0, 3.0543318, 16)
padding: 0 0 0 0
border: 0 0 0 0
margin: 0 0 0 0
text: " "